paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

streams: Do not use bootstrap CSS in stream privacy choices inputs.

Browse Source 
We rewrite the CSS rules, handled by bootstrap for the radio buttons
for stream privacy choices (in both stream create and edit form),
to subscriptions.css as we are in process of removing bootstrap.

The settings-radio-input-parent block in subscriptions.css is moved
to be top-level instead of being nested inside "stream_privacy_modal"
and "stream-creation-body" block, such that we can use this class
in future for resusable components (like settings_checkbox).

The bootstrap CSS rules are also added to this
settings-radio-input-parent selector.

The max-height property added to label by bootstrap is not added
since it does not applies to non-replaced inline elements.
The line-height property added to input element by bootstrap is
not added to subscriptions.css since it is already added for all
inputs in zulip.css.
This commit is contained in:
Sahil Batra
2022-11-22 15:58:25 +05:30
committed by Tim Abbott
parent 55aaf1d56d
commit d2b48fab27
1 changed files with 32 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
static/styles/subscriptions.css
View File

@@ -961,27 +961,43 @@ h4.user_group_setting_subsection_title {
vertical-align: middle;
}
div.settings-radio-input-parent {
border-bottom: 1px solid hsl(0, 0%, 87%);
margin: 2px 0 2px 5px;
padding: 2px 0;
&:last-of-type {
border-bottom: none;
}
label.radio {
display: inline;
margin: 5px;
padding-left: 0px;
}
input {
float: left;
width: auto;
cursor: pointer;
&:focus {
outline: 1px dotted hsl(0, 0%, 20%);
outline: 5px auto -webkit-focus-ring-color;
outline-offset: -2px;
}
&:disabled {
cursor: not-allowed;
}
}
}
#stream_privacy_modal,
.stream-creation-body {
.input-group {
margin-bottom: 10px;
.settings-radio-input-parent {
border-bottom: 1px solid hsl(0, 0%, 87%);
margin: 2px 0 2px 5px;
padding: 2px 0;
&:last-of-type {
border-bottom: none;
}
label.radio {
display: inline;
margin: 5px;
padding-left: 0;
}
}
&.message-retention-setting-group {
input {
width: 5ch;