paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Remove create_message_object.

Browse Source 
This will help with typescript conversion by reducing partially
formed message object types.
This commit is contained in:
Evy Kassirer
2025-09-01 20:12:05 -07:00
committed by Tim Abbott
parent 203da5008a
commit d2f7b1a7ac
4 changed files with 58 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
web/tests/compose.test.cjs
View File

@@ -850,36 +850,6 @@ test_ui("on_events", ({override, override_rewire}) => {
})();
});
test_ui("create_message_object", ({override, override_rewire}) => {
mock_banners();
const fake_compose_box = new FakeComposeBox();
compose_state.set_stream_id(social.stream_id);
fake_compose_box.set_topic_val("lunch");
fake_compose_box.set_textarea_val("burrito");
compose_state.set_message_type("stream");
let message = compose.create_message_object();
assert.equal(message.to, social.stream_id);
assert.equal(message.topic, "lunch");
assert.equal(message.content, "burrito");
compose_state.set_message_type("private");
override(compose_pm_pill, "get_emails", () => "alice@example.com,bob@example.com");
message = compose.create_message_object();
assert.deepEqual(message.to, [alice.user_id, bob.user_id]);
assert.equal(message.to_user_ids, "31,32");
assert.equal(message.content, "burrito");
override_rewire(people, "email_list_to_user_ids_string", () => undefined);
message = compose.create_message_object();
assert.deepEqual(message.to, [alice.email, bob.email]);
});
test_ui("DM policy disabled", ({override, override_rewire}) => {
// Disable dms in the organisation
override(realm, "realm_direct_message_permission_group", nobody.id);