paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

drafts: Rename open_modal -> open_overlay.

Browse Source 
We consider the drafts thing to be an overlay,
not a modal, so the old name was confusing.
This commit is contained in:
Steve Howell
2020-05-09 14:11:34 +00:00
committed by showell
parent 524d347c39
commit d3aded2ae7
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/node_tests/drafts.js
View File

@@ -320,7 +320,7 @@ run_test('format_drafts', () => {
return '<draft table stub>';
});
drafts.open_modal = noop;
drafts.open_overlay = noop;
drafts.set_initial_element = noop;
$("#drafts_table .draft-row").length = 0;

4
static/js/drafts.js
View File

@@ -360,7 +360,7 @@ exports.launch = function () {
// element in order for the CSS transition to take effect.
$('#draft_overlay').css('opacity');
exports.open_modal();
exports.open_overlay();
exports.set_initial_element(drafts);
setup_event_handlers();
};
@@ -485,7 +485,7 @@ exports.drafts_handle_events = function (e, event_key) {
}
};
exports.open_modal = function () {
exports.open_overlay = function () {
overlays.open_overlay({
name: 'drafts',
overlay: $('#draft_overlay'),