paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable Hot Module Replacement in webpack.

Browse Source 
This allow the webbpack dev server to properly reload JavaScript modules
while running in dev without restarting the server. We need to connect
to webpack-dev-server directly because SockJS doesn't support more than
one connection on the same host/port.
This commit is contained in:
Pweaver (Paul Weaver)
2017-07-16 15:14:03 -04:00
committed by Tim Abbott
parent 0718eb5220
commit d3ffc81726
6 changed files with 63 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tools/webpack
View File

@@ -25,11 +25,11 @@ def run():
subprocess.check_call(['node', 'node_modules/.bin/webpack'] +
['--config', 'tools/webpack.production.config.js', '-p'])
def run_watch(port, minify):
# type: (str, bool) -> None
def run_watch(host, port, minify):
# type: (str, str, bool) -> None
"""watches and rebuilds on changes, serving files from memory via webpack-dev-server"""
webpack_args = ['node', 'node_modules/.bin/webpack-dev-server']
webpack_args += ['--config', 'tools/webpack.dev.config.js', '--watch-poll', '--port', port]
webpack_args += ['--config', 'tools/webpack.dev.config.js', '--watch-poll', '--port', port, "--host", host]
if minify:
webpack_args.append('--optimize-minimize')
subprocess.Popen(webpack_args)
@@ -63,6 +63,9 @@ parser.add_argument('--test',
parser.add_argument('--watch',
action='store_true', dest='watch', default=False,
help='watch for changes to source files (for development)')
parser.add_argument('--host',
action='store', dest='host',
default='127.0.0.1', help='set the host for the webpack server to run on')
parser.add_argument('--port',
action='store', dest='port',
default='9994', help='set the port for the webpack server to run on')
@@ -74,6 +77,6 @@ args = parser.parse_args()
if args.test:
run_test()
elif args.watch:
run_watch(args.port, args.minify)
run_watch(args.host, args.port, args.minify)
else:
run()