paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 18:36:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

casper: Extract stream_checkbox helper.

Browse Source
This commit is contained in:
Steve Howell
2020-01-28 20:30:41 +00:00
committed by Tim Abbott
parent f3cfddce81
commit d40f18c4f0
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
frontend_tests/casper_tests/05-subscriptions.js
View File

@@ -1,5 +1,9 @@
var common = require('../casper_lib/common.js'); var common = require('../casper_lib/common.js');
function stream_checkbox(stream_name) {
return '#stream-checkboxes [data-stream-name="' + stream_name + '"]';
}
function user_checkbox(email) { function user_checkbox(email) {
var user_id = common.get_user_id(email); var user_id = common.get_user_id(email);
return '#user-checkboxes [data-user-id="' + user_id + '"]'; return '#user-checkboxes [data-user-id="' + user_id + '"]';
@@ -54,8 +58,8 @@ casper.waitUntilVisible("#copy-from-stream-expand-collapse", function () {
}); });
casper.waitUntilVisible("#stream-checkboxes", function () { casper.waitUntilVisible("#stream-checkboxes", function () {
casper.test.assertExists('#stream-checkboxes [data-stream-name="Scotland"]', 'Original stream list contains Scotland'); casper.test.assertExists(stream_checkbox('Scotland'), 'Original stream list contains Scotland');
casper.test.assertExists('#stream-checkboxes [data-stream-name="Rome"]', 'Original stream list contains Rome'); casper.test.assertExists(stream_checkbox('Rome'), 'Original stream list contains Rome');
}); });
casper.waitUntilVisible("form#stream_creation_form", function () { casper.waitUntilVisible("form#stream_creation_form", function () {
@@ -71,10 +75,10 @@ casper.waitUntilVisible("#user-checkboxes", function () {
"Othello is visible"); "Othello is visible");
/* The filter should not impact streams */ /* The filter should not impact streams */
casper.test.assertEquals(casper.visible('#stream-checkboxes [data-stream-name="Scotland"]'), casper.test.assertEquals(casper.visible(stream_checkbox('Scotland')),
true, true,
"Scotland is visible"); "Scotland is visible");
casper.test.assertEquals(casper.visible('#stream-checkboxes [data-stream-name="Rome"]'), casper.test.assertEquals(casper.visible(stream_checkbox('Rome')),
true, true,
"Rome is visible"); "Rome is visible");
}); });
@@ -110,10 +114,10 @@ casper.then(function () {
casper.test.assertEquals(casper.visible(user_checkbox('othello@zulip.com')), casper.test.assertEquals(casper.visible(user_checkbox('othello@zulip.com')),
true, true,
"Othello is visible again"); "Othello is visible again");
casper.test.assertEquals(casper.visible('#stream-checkboxes [data-stream-name="Scotland"]'), casper.test.assertEquals(casper.visible(stream_checkbox('Scotland')),
true, true,
"Scotland is visible again"); "Scotland is visible again");
casper.test.assertEquals(casper.visible('#stream-checkboxes [data-stream-name="Rome"]'), casper.test.assertEquals(casper.visible(stream_checkbox('Rome')),
true, true,
"Rome is visible again"); "Rome is visible again");
}); });