paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

keydown_util: Extract all 'Enter' events to one place.

Browse Source 
This is a prep commit to fix #22062.
This commit is contained in:
Rohitt Vashishtha
2022-09-28 11:57:24 +05:30
committed by Tim Abbott
parent aeb9a27d0e
commit d4379f9528
21 changed files with 51 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
static/js/search.js
View File

@@ -3,6 +3,7 @@ import $ from "jquery";
import render_search_list_item from "../templates/search_list_item.hbs";
import {Filter} from "./filter";
import * as keydown_util from "./keydown_util";
import * as message_view_header from "./message_view_header";
import * as narrow from "./narrow";
import * as narrow_state from "./narrow_state";
@@ -136,7 +137,7 @@ export function initialize() {
$searchbox_form
.on("keydown", (e) => {
update_button_visibility();
if (e.key === "Enter" && $search_query_box.is(":focus")) {
if (keydown_util.is_enter_event(e) && $search_query_box.is(":focus")) {
// Don't submit the form so that the typeahead can instead
// handle our Enter keypress. Any searching that needs
// to be done will be handled in the keyup.
@@ -149,7 +150,7 @@ export function initialize() {
return;
}
if (e.key === "Enter" && $search_query_box.is(":focus")) {
if (keydown_util.is_enter_event(e) && $search_query_box.is(":focus")) {
// We just pressed Enter and the box had focus, which
// means we didn't use the typeahead at all. In that
// case, we should act as though we're searching by