paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

streams: Make sure that unused anonymous groups are not created.

Browse Source 
Anonymous groups were being created for stream permission
settings when calling the subscriptions endpoint without
any streams data or when calling it only for subscribing
users to streams and not for creating any new streams.

This commit makes sure that no such unused anonymous groups
are created.
This commit is contained in:
Sahil Batra
2025-09-08 21:03:44 +05:30
committed by Tim Abbott
parent 1e21f7b224
commit d4d7a8fe2a
5 changed files with 110 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
zerver/tests/test_channel_creation.py
View File

@@ -1056,8 +1056,13 @@ class TestCreateStreams(ZulipTestCase):
"is_web_public": False,
}
]
request_settings_dict = dict.fromkeys(Stream.stream_permission_group_settings)
with self.assertRaisesRegex(JsonableError, "Must be an organization owner"):
list_to_streams(streams_raw, admin, autocreate=True)
list_to_streams(
streams_raw, admin, autocreate=True, request_settings_dict=request_settings_dict
)
streams_raw = [
{
@@ -1067,7 +1072,9 @@ class TestCreateStreams(ZulipTestCase):
}
]
with self.assertRaisesRegex(JsonableError, "Must be an organization owner"):
list_to_streams(streams_raw, admin, autocreate=True)
list_to_streams(
streams_raw, admin, autocreate=True, request_settings_dict=request_settings_dict
)
streams_raw = [
{
@@ -1076,7 +1083,9 @@ class TestCreateStreams(ZulipTestCase):
"is_web_public": False,
}
]
result = list_to_streams(streams_raw, admin, autocreate=True)
result = list_to_streams(
streams_raw, admin, autocreate=True, request_settings_dict=request_settings_dict
)
self.assert_length(result[0], 0)
self.assert_length(result[1], 1)
self.assertEqual(result[1][0].name, "new_stream")
@@ -1105,10 +1114,14 @@ class TestCreateStreams(ZulipTestCase):
with self.assertRaisesRegex(
JsonableError, "Available on Zulip Cloud Standard. Upgrade to access."
):
list_to_streams(streams_raw, owner, autocreate=True)
list_to_streams(
streams_raw, owner, autocreate=True, request_settings_dict=request_settings_dict
)
do_change_realm_plan_type(realm, Realm.PLAN_TYPE_SELF_HOSTED, acting_user=admin)
result = list_to_streams(streams_raw, owner, autocreate=True)
result = list_to_streams(
streams_raw, owner, autocreate=True, request_settings_dict=request_settings_dict
)
self.assert_length(result[0], 0)
self.assert_length(result[1], 3)
self.assertEqual(result[1][0].name, "new_stream1")