paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

server_events_dispatch: Refactor realm_bot case to use switch/case.

Browse Source 
This should make no functional changes.
This commit is contained in:
YashRE42
2020-10-15 12:08:49 +00:00
committed by Tim Abbott
parent b89363cec3
commit d50bc7441a
1 changed files with 20 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
static/js/server_events_dispatch.js
View File

@@ -296,21 +296,28 @@ export function dispatch_normal_event(event) {
}
case "realm_bot":
if (event.op === "add") {
bot_data.add(event.bot);
} else if (event.op === "remove") {
bot_data.deactivate(event.bot.user_id);
event.bot.is_active = false;
} else if (event.op === "delete") {
blueslip.info("ignoring bot deletion for live UI update");
break;
} else if (event.op === "update") {
bot_data.update(event.bot.user_id, event.bot);
switch (event.op) {
case "add":
bot_data.add(event.bot);
settings_bots.eventually_render_bots();
settings_users.update_bot_data(event.bot.user_id);
break;
case "remove":
bot_data.deactivate(event.bot.user_id);
event.bot.is_active = false;
settings_bots.eventually_render_bots();
settings_users.update_bot_data(event.bot.user_id);
break;
case "delete":
blueslip.info("ignoring bot deletion for live UI update");
break;
case "update":
bot_data.update(event.bot.user_id, event.bot);
settings_bots.eventually_render_bots();
settings_users.update_bot_data(event.bot.user_id);
break;
}
settings_bots.eventually_render_bots();
settings_users.update_bot_data(event.bot.user_id);
break;
case "realm_emoji":
// The authoritative data source is here.
emoji.update_emojis(event.realm_emoji);