paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-20 22:48:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

modals: Rename is_modal_open to is_open.

Browse Source
This commit is contained in:
Aman Agrawal
2023-10-10 12:29:09 +00:00
committed by Tim Abbott
parent 577a384845
commit d54a917104
7 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
web/src/modals.ts
View File

@@ -31,12 +31,12 @@ function call_hooks(func_list: Hook[]): void {
}
}
export function is_modal_open(): boolean {
export function is_open(): boolean {
return $(".micromodal").hasClass("modal--open");
}
export function active_modal(): string | undefined {
if (!is_modal_open()) {
if (!is_open()) {
blueslip.error("Programming error — Called active_modal when there is no modal open");
return undefined;
}
@@ -68,10 +68,10 @@ export function open_modal(
return;
}
if (is_modal_open()) {
if (is_open()) {
/*
Our modal system doesn't directly support opening a modal
when one is already open, because the `is_modal_open` CSS
when one is already open, because the `is_open` CSS
class doesn't update until Micromodal has finished its
animations, which can take 100ms or more.
@@ -178,8 +178,8 @@ export function close_modal(modal_id: string, conf: Pick<ModalConfig, "on_hidden
return;
}
if (!is_modal_open()) {
blueslip.warn("close_active_modal() called without checking is_modal_open()");
if (!is_open()) {
blueslip.warn("close_active_modal() called without checking is_open()");
return;
}
@@ -213,7 +213,7 @@ export function close_modal_if_open(modal_id: string): void {
return;
}
if (!is_modal_open()) {
if (!is_open()) {
return;
}
@@ -229,8 +229,8 @@ export function close_modal_if_open(modal_id: string): void {
}
export function close_active_modal(): void {
if (!is_modal_open()) {
blueslip.warn("close_active_modal() called without checking is_modal_open()");
if (!is_open()) {
blueslip.warn("close_active_modal() called without checking is_open()");
return;
}