paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Call unread.process_loaded_messages earlier when inserting.

Browse Source 
We want to maintain the invariant that unread.js always knows
about unread messages as soon as they are loaded.
This commit is contained in:
Steve Howell
2017-08-03 23:54:02 -04:00
committed by Tim Abbott
parent a07bd70449
commit d5681556d5
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
static/js/message_events.js
View File

@@ -56,8 +56,8 @@ function maybe_add_narrowed_messages(messages, msg_list, messages_are_new) {
exports.insert_new_messages = function insert_new_messages(messages, locally_echoed) { exports.insert_new_messages = function insert_new_messages(messages, locally_echoed) {
messages = _.map(messages, message_store.add_message_metadata); messages = _.map(messages, message_store.add_message_metadata);
// You must add add messages to home_msg_list BEFORE unread.process_loaded_messages(messages);
// calling unread.process_loaded_messages.
message_util.add_messages(messages, home_msg_list, {messages_are_new: true}); message_util.add_messages(messages, home_msg_list, {messages_are_new: true});
message_util.add_messages(messages, message_list.all, {messages_are_new: true}); message_util.add_messages(messages, message_list.all, {messages_are_new: true});
@@ -77,7 +77,6 @@ exports.insert_new_messages = function insert_new_messages(messages, locally_ech
activity.process_loaded_messages(messages); activity.process_loaded_messages(messages);
unread.process_loaded_messages(messages);
unread_ui.update_unread_counts(); unread_ui.update_unread_counts();
resize.resize_page_components(); resize.resize_page_components();