stream_privacy_setting_modal: Migrate modal to dialog_widget.

static/js/stream_edit.js

@@ -5,9 +5,9 @@ import render_unsubscribe_private_stream_modal from "../templates/confirm_dialog
 import render_change_stream_info_modal from "../templates/stream_settings/change_stream_info_modal.hbs";
 import render_stream_description from "../templates/stream_settings/stream_description.hbs";
 import render_stream_member_list_entry from "../templates/stream_settings/stream_member_list_entry.hbs";
-import render_stream_privacy_setting_modal from "../templates/stream_settings/stream_privacy_setting_modal.hbs";
 import render_stream_settings from "../templates/stream_settings/stream_settings.hbs";
 import render_stream_subscription_request_result from "../templates/stream_settings/stream_subscription_request_result.hbs";
+import render_stream_types from "../templates/stream_settings/stream_types.hbs";
 
 import * as blueslip from "./blueslip";
 import * as browser_history from "./browser_history";
@@ -649,7 +649,7 @@ function change_stream_privacy(e) {
     e.stopPropagation();
 
     const data = {};
-    const stream_id = $(e.target).data("stream-id");
+    const stream_id = $(e.target).closest(".dialog_submit_button").data("stream-id");
     const url = "/json/streams/" + stream_id;
     const status_element = $(".stream_permission_change_info");
     const sub = sub_store.get(stream_id);
@@ -723,8 +723,6 @@ function change_stream_privacy(e) {
         data.message_retention_days = JSON.stringify(message_retention_days);
     }
 
-    overlays.close_modal("#stream_privacy_modal");
-
     if (Object.keys(data).length === 0) {
         return;
     }
@@ -762,8 +760,6 @@ export function initialize() {
         const stream = sub_store.get(stream_id);
 
         const template_data = {
-            stream_id,
-            stream_name: stream.name,
             stream_privacy_policy_values: stream_data.stream_privacy_policy_values,
             stream_privacy_policy: stream_data.get_stream_privacy_policy(stream_id),
             stream_post_policy_values: stream_data.stream_post_policy_values,
@@ -779,17 +775,31 @@ export function initialize() {
                 page_params.upgrade_text_for_wide_organization_logo,
             is_stream_edit: true,
         };
-        const change_privacy_modal = render_stream_privacy_setting_modal(template_data);
+        const change_privacy_modal = render_stream_types(template_data);
-        $("#stream_privacy_modal").remove();
+
-        $("#subscriptions_table").append(change_privacy_modal);
+        dialog_widget.launch({
-        set_stream_message_retention_setting_dropdown(stream);
+            html_heading: $t_html(
-        overlays.open_modal("#stream_privacy_modal");
+                {defaultMessage: "Change stream permissions for #{stream_name}"},
+                {stream_name: stream.name},
+            ),
+            html_body: change_privacy_modal,
+            close_on_submit: true,
+            id: "stream_privacy_modal",
+            on_click: change_stream_privacy,
+            post_render: () => {
+                $("#stream_privacy_modal .dialog_submit_button").attr("data-stream-id", stream_id);
+                set_stream_message_retention_setting_dropdown(stream);
+
+                $(".stream_message_retention_setting").on("change", (e) => {
+                    const dropdown_value = e.target.value;
+                    change_stream_message_retention_days_block_display_property(dropdown_value);
+                });
+            },
+        });
         e.preventDefault();
         e.stopPropagation();
     });
 
-    $("#subscriptions_table").on("click", "#change-stream-privacy-button", change_stream_privacy);
-
     $("#subscriptions_table").on("click", "#open_stream_info_modal", (e) => {
         e.preventDefault();
         e.stopPropagation();
@@ -1010,9 +1020,4 @@ export function initialize() {
             open_edit_panel_for_row(this);
         }
     });
-
-    $("#subscriptions_table").on("change", ".stream_message_retention_setting", (e) => {
-        const dropdown_value = e.target.value;
-        change_stream_message_retention_days_block_display_property(dropdown_value);
-    });
 }

static/templates/stream_settings/stream_privacy_setting_modal.hbs

@@ -1,16 +0,0 @@
-<div id="stream_privacy_modal" class="modal modal-bg hide fade new-style" tabindex="-1" role="dialog" aria-labelledby="stream_privacy_modal_label" aria-hidden="true">
-    <div class="modal-header">
-        <button type="button" class="close close-modal-btn" data-dismiss="modal" aria-label="{{t 'Close' }}"><span aria-hidden="true">&times;</span></button>
-        <h3 id="stream_privacy_modal_label">{{#tr}}Change stream permissions for #{stream_name}{{/tr}}<span class="email"></span></h3>
-    </div>
-    <div class="modal-body">
-        {{> stream_types }}
-    </div>
-    <div class="modal-footer">
-        <button class="button rounded close-modal-btn" data-dismiss="modal">{{t "Cancel" }}</button>
-        <button class="button rounded btn-danger" id="change-stream-privacy-button"
-          tabindex="-1" data-stream-id="{{stream_id}}">
-            {{t "Save changes"}}
-        </button>
-    </div>
-</div>

static/templates/stream_settings/stream_types.hbs

@@ -1,4 +1,4 @@
-<div class="grey-box">
+<div class="grey-box new-style">
     <div class="input-group">
         <div class="alert stream-privacy-status"></div>
         <h4>{{t 'Who can access the stream?'}}