From d69c40eb75e9500973bcc452ee694c908f67c55b Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Thu, 9 Feb 2017 21:58:09 -0800 Subject: [PATCH] casper: Clean up some admin casper tests. This adds missing casper.then(), some waits for relevant selectors, and tightens some of the selectors to be more precise. --- frontend_tests/casper_tests/10-admin.js | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/frontend_tests/casper_tests/10-admin.js b/frontend_tests/casper_tests/10-admin.js index cf8a9678f3..f6dec71233 100644 --- a/frontend_tests/casper_tests/10-admin.js +++ b/frontend_tests/casper_tests/10-admin.js @@ -284,21 +284,28 @@ casper.then(function () { // TODO: Test stream deletion casper.then(function () { - casper.test.info("Changing realm default language"); - casper.evaluate(function () { - $('#id_realm_default_language').val('de').change(); + casper.waitUntilVisible('#id_realm_default_language', function () { + casper.test.info("Changing realm default language"); + casper.evaluate(function () { + $('#id_realm_default_language').val('de').change(); + }); + casper.click('form.admin-realm-form input.button'); }); - casper.click('form.admin-realm-form input.button'); }); -casper.waitUntilVisible('#admin-realm-default-language-status', function () { - casper.test.assertSelectorHasText('#admin-realm-default-language-status', 'Default language changed!'); +casper.then(function () { + casper.waitUntilVisible('#admin-realm-default-language-status', function () { + casper.test.assertSelectorHasText('#admin-realm-default-language-status', + 'Default language changed!'); + }); }); // Test authentication methods setting -casper.waitForSelector('input[type="checkbox"]', function () { - casper.click(".method_row[data-method='Email'] input[type='checkbox']"); - casper.click('form.admin-realm-form input.button'); +casper.then(function () { + casper.waitForSelector(".method_row[data-method='Email'] input[type='checkbox']", function () { + casper.click(".method_row[data-method='Email'] input[type='checkbox']"); + casper.click('form.admin-realm-form input.button'); + }); }); // Test setting was activated--default is checked