paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

eslint: Replace empty-returns with consistent-return.

Browse Source 
Instead of prohibiting ‘return undefined’ (#8669), we require that a
function must return an explicit value always or never.  This prevents
you from forgetting to return a value in some cases.  It will also be
important for TypeScript, which distinguishes between undefined and
void.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2020-09-23 22:50:36 -07:00
committed by Tim Abbott
parent fe66aef0ad
commit d72423ef21
103 changed files with 331 additions and 247 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
static/js/message_list_data.js
View File

@@ -46,13 +46,13 @@ class MessageListData {
select_idx() {
if (this._selected_id === -1) {
return;
return undefined;
}
const ids = this._items.map((message) => message.id);
const i = ids.indexOf(this._selected_id);
if (i === -1) {
return;
return undefined;
}
return i;
}
@@ -61,11 +61,11 @@ class MessageListData {
const i = this.select_idx();
if (i === undefined) {
return;
return undefined;
}
if (i === 0) {
return;
return undefined;
}
return this._items[i - 1].id;
@@ -75,11 +75,11 @@ class MessageListData {
const i = this.select_idx();
if (i === undefined) {
return;
return undefined;
}
if (i + 1 >= this._items.length) {
return;
return undefined;
}
return this._items[i + 1].id;
@@ -121,7 +121,7 @@ class MessageListData {
get(id) {
id = parseFloat(id);
if (isNaN(id)) {
return;
return undefined;
}
return this._hash.get(id);
}
@@ -531,7 +531,7 @@ class MessageListData {
get_last_message_sent_by_me() {
const msg_index = _.findLastIndex(this._items, {sender_id: page_params.user_id});
if (msg_index === -1) {
return;
return undefined;
}
const msg = this._items[msg_index];
return msg;