paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 19:06:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose_banner: Replace the close button with "Got it" button.

Browse Source 
For onboarding banners, we replace the close button with
"Got it" button.

Also, the banner is marked as read for the user only after
the "Got it" button is clicked. Earlier it was marked as read
as soon as it was displayed.
This commit is contained in:
Prakhar Pratyush
2024-05-01 12:14:53 +05:30
committed by Tim Abbott
parent a35b922f05
commit d7a9523170
5 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/src/compose_setup.js
View File

@@ -18,6 +18,7 @@ import * as flatpickr from "./flatpickr";
import {$t_html} from "./i18n";
import * as message_edit from "./message_edit";
import * as narrow from "./narrow";
import * as onboarding_steps from "./onboarding_steps";
import {page_params} from "./page_params";
import * as poll_modal from "./poll_modal";
import * as popovers from "./popovers";
@@ -212,13 +213,19 @@ export function initialize() {
},
);
const automatic_new_visibility_policy_banner_selector = `.${CSS.escape(compose_banner.CLASSNAMES.automatic_new_visibility_policy)}`;
$("body").on(
"click",
`.${CSS.escape(
compose_banner.CLASSNAMES.automatic_new_visibility_policy,
)} .main-view-banner-action-button`,
`${automatic_new_visibility_policy_banner_selector} .main-view-banner-action-button`,
(event) => {
event.preventDefault();
if ($(event.target).attr("data-action") === "mark-as-read") {
$(event.target)
.parents(`${automatic_new_visibility_policy_banner_selector}`)
.remove();
onboarding_steps.post_onboarding_step_as_read("visibility_policy_banner");
return;
}
window.location.href = "/#settings/notifications";
},
);