paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

streams: Optimize stream_data.create_sub_from_server_data.

Browse Source 
This is definitely a micro-optimization, but avoiding
creating an extra object speeds up page loads by about
20ms per 1000 streams.

It's slightly sketchy to mutate the value in place, but
the original value never gets used again.
This commit is contained in:
Steve Howell
2018-11-29 20:50:20 +00:00
committed by Tim Abbott
parent 6781345b9b
commit d8c8fc1f03
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
static/js/stream_data.js
View File

@@ -443,11 +443,16 @@ exports.create_sub_from_server_data = function (stream_name, attrs) {
// Our internal data structure for subscriptions is mostly plain dictionaries, // Our internal data structure for subscriptions is mostly plain dictionaries,
// so we just reuse the attrs that are passed in to us, but we encapsulate how // so we just reuse the attrs that are passed in to us, but we encapsulate how
// we handle subscribers. // we handle subscribers. We defensively remove the `subscribers` field from
var subscriber_user_ids = attrs.subscribers; // the original `attrs` object, which will get thrown away. (We used to make
var raw_attrs = _.omit(attrs, 'subscribers'); // a copy of the object with `_.omit(attrs, 'subscribers')`, but `_.omit` is
// slow enough to show up in timings when you have 1000s of streams.
sub = _.defaults(raw_attrs, { var subscriber_user_ids = attrs.subscribers;
delete attrs.subscribers;
sub = _.defaults(attrs, {
name: stream_name, name: stream_name,
render_subscribers: !page_params.realm_is_zephyr_mirror_realm || attrs.invite_only === true, render_subscribers: !page_params.realm_is_zephyr_mirror_realm || attrs.invite_only === true,
subscribed: true, subscribed: true,