paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Fix compose banner click handlers when editing messages.

Browse Source 
The click handlers for compose banners, many of which can appear both
in the message editing code path and above the compose box, were
incorrectly scoped to only the #compose_banners container.

These click handlers were all overly specific; they already have a
very unique selector in the form of things like
.compose_banner_close_button, and more shouldn't be necessary.
This commit is contained in:
Tim Abbott
2023-05-02 13:02:56 -07:00
parent 3d3d30166d
commit d96fac2b59
1 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
web/src/compose.js
View File

@@ -465,7 +465,7 @@ export function initialize() {
upload.feature_check($("#compose .compose_upload_file"));
$("#compose_banners").on(
$("body").on(
"click",
`.${CSS.escape(compose_banner.CLASSNAMES.wildcard_warning)} .compose_banner_action_button`,
(event) => {
@@ -479,7 +479,7 @@ export function initialize() {
const user_not_subscribed_selector = `.${CSS.escape(
compose_banner.CLASSNAMES.user_not_subscribed,
)}`;
$("#compose_banners").on(
$("body").on(
"click",
`${user_not_subscribed_selector} .compose_banner_action_button`,
(event) => {
@@ -495,7 +495,7 @@ export function initialize() {
},
);
$("#compose_banners").on(
$("body").on(
"click",
`.${CSS.escape(compose_banner.CLASSNAMES.topic_resolved)} .compose_banner_action_button`,
(event) => {
@@ -512,7 +512,7 @@ export function initialize() {
},
);
$("#compose_banners").on(
$("body").on(
"click",
`.${CSS.escape(
compose_banner.CLASSNAMES.unmute_topic_notification,
@@ -534,7 +534,7 @@ export function initialize() {
},
);
$("#compose_banners").on(
$("body").on(
"click",
`.${CSS.escape(
compose_banner.CLASSNAMES.recipient_not_subscribed,
@@ -574,14 +574,10 @@ export function initialize() {
for (const classname of Object.values(compose_banner.CLASSNAMES)) {
const classname_selector = `.${CSS.escape(classname)}`;
$("#compose_banners").on(
"click",
`${classname_selector} .compose_banner_close_button`,
(event) => {
event.preventDefault();
$(event.target).parents(classname_selector).remove();
},
);
$("body").on("click", `${classname_selector} .compose_banner_close_button`, (event) => {
event.preventDefault();
$(event.target).parents(classname_selector).remove();
});
}
// Click event binding for "Attach files" button