paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

widgetize: Don't warn for deleted tictactoe widget.

Browse Source
This commit is contained in:
YashRE42
2020-11-09 10:22:48 +00:00
committed by Steve Howell
parent 909b484d64
commit d9b14b5b74
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
frontend_tests/node_tests/widgetize.js
View File

@@ -135,6 +135,13 @@ run_test("activate", () => {
assert(!is_event_handled); assert(!is_event_handled);
assert.equal(blueslip.get_test_logs("warn")[0].more_info, "invalid_widget"); assert.equal(blueslip.get_test_logs("warn")[0].more_info, "invalid_widget");
opts.widget_type = "tictactoe";
widgetize.activate(opts);
assert(!is_widget_elem_inserted);
assert(!is_widget_activated);
assert(!is_event_handled);
/* Testing widgetize.handle_events */ /* Testing widgetize.handle_events */
const post_activate_event = { const post_activate_event = {
data: { data: {

3
static/js/widgetize.js
View File

@@ -25,6 +25,9 @@ exports.activate = function (in_opts) {
events.shift(); events.shift();
if (!widgets.has(widget_type)) { if (!widgets.has(widget_type)) {
if (widget_type === "tictactoe") {
return; // don't warn for deleted legacy widget
}
blueslip.warn("unknown widget_type", widget_type); blueslip.warn("unknown widget_type", widget_type);
return; return;
} }