paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-28 18:43:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_groups: Rename get_user_group_direct_members function.

Browse Source 
This commit renames get_user_group_direct_members function to
get_user_group_direct_member_ids as it returns a list of ids
and to avoid it being parallel to get_recursive_group_members,
which returns a QuerySet.
This commit is contained in:
Sahil Batra
2022-04-27 15:29:25 +05:30
committed by Tim Abbott
parent 0f01e3d327
commit d9d27b459d
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/lib/email_notifications.py
View File

@@ -32,7 +32,7 @@ from zerver.lib.url_encoding import (
stream_narrow_url,
topic_narrow_url,
)
from zerver.lib.user_groups import get_user_group_direct_members
from zerver.lib.user_groups import get_user_group_direct_member_ids
from zerver.models import (
Message,
Recipient,
@@ -372,7 +372,7 @@ def get_mentioned_user_group_name(
smallest_user_group_name = None
for user_group_id in mentioned_user_group_ids:
current_user_group = UserGroup.objects.get(id=user_group_id, realm=user_profile.realm)
current_user_group_size = len(get_user_group_direct_members(current_user_group))
current_user_group_size = len(get_user_group_direct_member_ids(current_user_group))
if current_user_group_size < smallest_user_group_size:
# If multiple user groups are mentioned, we prefer the