From d9d7c5500621933ba9a54d554f77acea70e00b3a Mon Sep 17 00:00:00 2001 From: Ganesh Pawar Date: Mon, 21 Jun 2021 16:13:49 +0530 Subject: [PATCH] user_deactivation: Move modal_parent one level up in the DOM. The user deactivate button is also present in the "Deactivated users" tab, a sibling element of the current modal_parent, #admin-user-list. Adding the confirm_dialog modal to #admin-user-list won't have any effect in the "Deactivated users" tab. Move it one level up, i.e. to the parent element of #admin-user-list and #admin-deactivated-users-list. Fixes #18928. --- static/js/settings_users.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/js/settings_users.js b/static/js/settings_users.js index db1b80f3e6..5a90fbb712 100644 --- a/static/js/settings_users.js +++ b/static/js/settings_users.js @@ -490,7 +490,7 @@ function open_bot_form(person) { function confirm_deactivation(row, user_id, status_field) { const user = people.get_by_user_id(user_id); - const modal_parent = $("#admin-user-list"); + const modal_parent = $("#settings_content .organization-box"); const opts = { username: user.full_name, email: user.email,