paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 18:06:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

puppeteer_tests: Log page errors.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-03-24 14:52:12 -07:00
committed by Tim Abbott
parent ed8c4fec98
commit da9783fd10
1 changed files with 33 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
frontend_tests/puppeteer_lib/common.ts
View File

@@ -2,7 +2,7 @@ import {strict as assert} from "assert";
import "css.escape"; import "css.escape";
import path from "path"; import path from "path";
import type {Browser, ConsoleMessage, ElementHandle, Page} from "puppeteer"; import type {Browser, ConsoleMessage, ConsoleMessageLocation, ElementHandle, Page} from "puppeteer";
import {launch} from "puppeteer"; import {launch} from "puppeteer";
import {test_credentials} from "../../var/puppeteer/test_credentials"; import {test_credentials} from "../../var/puppeteer/test_credentials";
@@ -492,25 +492,48 @@ class CommonUtils {
// a screenshot of it when the test fails. // a screenshot of it when the test fails.
const browser = await this.ensure_browser(); const browser = await this.ensure_browser();
const page = await this.get_page(); const page = await this.get_page();
page.on("console", (message: ConsoleMessage) => { page.on("console", (message: ConsoleMessage) => {
const {url, lineNumber, columnNumber} = message.location(); function context({url, lineNumber, columnNumber}: ConsoleMessageLocation): string {
console.log( if (lineNumber === undefined || columnNumber === undefined) {
`${url}:${lineNumber + 1}:${columnNumber}: ${message.type()}: ${message.text()}`, return `${url}`;
); }
return `${url}:${lineNumber + 1}:${columnNumber + 1}`;
}
console.log(`${context(message.location())}: ${message.type()}: ${message.text()}`);
if (message.type() === "trace") { if (message.type() === "trace") {
for (const {url, lineNumber, columnNumber} of message.stackTrace()) { for (const frame of message.stackTrace()) {
console.log(` at ${url}:${lineNumber + 1}:${columnNumber}`); console.log(` at ${context(frame)}`);
} }
} }
}); });
let page_errored = false;
page.on("pageerror", async (error: Error) => {
console.error("Page error:", error);
page_errored = true;
try {
// Take a screenshot, and increment the screenshot_id.
await this.screenshot(page, `failure-${this.screenshot_id}`);
this.screenshot_id += 1;
} finally {
console.log("Closing page to stop the test...");
await page.close();
}
});
try { try {
await test_function(page); await test_function(page);
} catch (error: unknown) { } catch (error: unknown) {
console.log(error); console.log(error);
// Take a screenshot, and increment the screenshot_id. if (!page_errored) {
await this.screenshot(page, `failure-${this.screenshot_id}`); // Take a screenshot, and increment the screenshot_id.
this.screenshot_id += 1; await this.screenshot(page, `failure-${this.screenshot_id}`);
this.screenshot_id += 1;
}
await browser.close(); await browser.close();
process.exit(1); process.exit(1);