paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 02:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extract get_subscribers_query

Browse Source 
(imported from commit fea253591093a1f0cf722c1d4bcfb0df4f881984)
This commit is contained in:
Steve Howell
2013-09-13 13:22:28 -04:00
parent b2a7860d56
commit db2c9ff8c2
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
zerver/lib/actions.py
View File

@@ -599,8 +599,8 @@ def get_subscription(stream_name, user_profile):
return Subscription.objects.get(user_profile=user_profile, return Subscription.objects.get(user_profile=user_profile,
recipient=recipient, active=True) recipient=recipient, active=True)
def get_subscribers(stream, realm=None, requesting_user=None): def get_subscribers_query(stream, realm, requesting_user):
""" Get the subscribers list for a stream, raising a JsonableError if: """ Build a query to get the subscribers list for a stream, raising a JsonableError if:
* No stream by that name exists in the realm. * No stream by that name exists in the realm.
* The realm is MIT and the stream is not invite only. * The realm is MIT and the stream is not invite only.
* The stream is invite only, requesting_user is passed, and that user * The stream is invite only, requesting_user is passed, and that user
@@ -608,6 +608,9 @@ def get_subscribers(stream, realm=None, requesting_user=None):
'stream' can either be a string representing a stream name, or a Stream 'stream' can either be a string representing a stream name, or a Stream
object. If it's a Stream object, 'realm' is optional. object. If it's a Stream object, 'realm' is optional.
The caller can refine this query with select_related(), values(), etc. depending
on whether it wants objects or just certain fields
""" """
try: try:
@@ -637,8 +640,12 @@ def get_subscribers(stream, realm=None, requesting_user=None):
subscriptions = Subscription.objects.filter(recipient__type=Recipient.STREAM, subscriptions = Subscription.objects.filter(recipient__type=Recipient.STREAM,
recipient__type_id=stream.id, recipient__type_id=stream.id,
user_profile__is_active=True, user_profile__is_active=True,
active=True).select_related() active=True)
return subscriptions
def get_subscribers(stream, realm=None, requesting_user=None):
subscriptions = get_subscribers_query(stream, realm, requesting_user).select_related()
return [subscription.user_profile for subscription in subscriptions] return [subscription.user_profile for subscription in subscriptions]
def maybe_get_subscribers(stream): def maybe_get_subscribers(stream):