paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_groups: Disable permission tab for deactivated groups.

Browse Source 
Since there can't be any permissions to display there, it seems not
helpful.
This commit is contained in:
Harsh
2025-03-09 18:58:45 +05:30
committed by Tim Abbott
parent f4bb1ac30f
commit db53482685
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
web/src/user_group_edit.ts
View File

@@ -503,8 +503,18 @@ export function update_group_details(group: UserGroup): void {
$edit_container.find(".group-description").text(group.description); $edit_container.find(".group-description").text(group.description);
} }
function update_toggler_for_group_setting(): void { function update_toggler_for_group_setting(group: UserGroup): void {
if (!group.deactivated) {
toggler.enable_tab("permissions");
toggler.goto(select_tab); toggler.goto(select_tab);
} else {
if (select_tab === "permissions") {
toggler.goto("general");
} else {
toggler.goto(select_tab);
}
toggler.disable_tab("permissions");
}
} }
function get_membership_status_context(group: UserGroup): { function get_membership_status_context(group: UserGroup): {
@@ -989,7 +999,7 @@ export function show_settings_for(group: UserGroup): void {
}); });
scroll_util.get_content_element($("#user_group_settings")).html(html); scroll_util.get_content_element($("#user_group_settings")).html(html);
update_toggler_for_group_setting(); update_toggler_for_group_setting(group);
toggler.get().prependTo("#user_group_settings .tab-container"); toggler.get().prependTo("#user_group_settings .tab-container");
const $edit_container = get_edit_container(group); const $edit_container = get_edit_container(group);
@@ -1895,7 +1905,7 @@ export function initialize(): void {
$("#dialog_error .permissions-button").on("click", () => { $("#dialog_error .permissions-button").on("click", () => {
select_tab = "permissions"; select_tab = "permissions";
update_toggler_for_group_setting(); update_toggler_for_group_setting(user_group);
dialog_widget.close(); dialog_widget.close();
}); });
} else { } else {