From dbd0fae6af0fb6984d84d2ab60a1a3b622d216f2 Mon Sep 17 00:00:00 2001 From: Sahil Batra Date: Tue, 18 Jun 2024 15:59:17 +0530 Subject: [PATCH] group_settings: Update save discard buttons when live-updating. This commit adds code to hide save discard buttons and discard the changes if another user changed a setting in the same subsection. --- web/src/user_group_edit.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/web/src/user_group_edit.js b/web/src/user_group_edit.js index 2ca1e82bad..35a4caabec 100644 --- a/web/src/user_group_edit.js +++ b/web/src/user_group_edit.js @@ -250,7 +250,15 @@ export function update_settings_pane(group) { $edit_container.find(".group-name").text(group.name); $edit_container.find(".group-description").text(group.description); - settings_org.discard_group_property_element_changes($("#id_can_mention_group"), group); + const $subsection = $edit_container.find(".settings-subsection-parent"); + // We currently have only one group-level setting, so it is + // fine to just call the function to discard changes in the + // complete subsection. + // + // We can update this code to be similar to how we handle realm + // settings in settings_org.sync_realm_settings when we add more + // group-level settings. + settings_org.discard_group_settings_subsection_changes($subsection, group); } function update_toggler_for_group_setting() {