From dc61ad60712633a171271a677e1951b68f39af86 Mon Sep 17 00:00:00 2001 From: Pratik Chanda Date: Wed, 20 Aug 2025 20:41:20 +0530 Subject: [PATCH] keyboard_shortcuts: Change selector for home view hotkey in help menu. This commit changes the selector for home view hotkey shortcut hint in help menu. This will help in internationalization of the keyboard hints. --- web/src/info_overlay.ts | 2 +- web/src/server_events_dispatch.js | 5 ++++- web/templates/keyboard_shortcuts.hbs | 2 +- web/tests/dispatch.test.cjs | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/web/src/info_overlay.ts b/web/src/info_overlay.ts index 678fcb4d23..3f78048656 100644 --- a/web/src/info_overlay.ts +++ b/web/src/info_overlay.ts @@ -330,7 +330,7 @@ export function set_up_toggler(): void { $(".informational-overlays .overlay-tabs").append($elem); - $("#go-to-home-view-hotkey-help").toggleClass( + $("#keyboard-shortcuts .go-to-home-view-hotkey-help").toggleClass( "notdisplayed", !user_settings.web_escape_navigates_to_home_view, ); diff --git a/web/src/server_events_dispatch.js b/web/src/server_events_dispatch.js index 023dcf0679..d068cbce25 100644 --- a/web/src/server_events_dispatch.js +++ b/web/src/server_events_dispatch.js @@ -1061,7 +1061,10 @@ export function dispatch_normal_event(event) { message_live_update.rerender_messages_view(); } if (event.property === "web_escape_navigates_to_home_view") { - $("#go-to-home-view-hotkey-help").toggleClass("notdisplayed", !event.value); + $("#keyboard-shortcuts .go-to-home-view-hotkey-help").toggleClass( + "notdisplayed", + !event.value, + ); } if (event.property === "web_suggest_update_timezone") { $("#automatically_offer_update_time_zone").prop("checked", event.value); diff --git a/web/templates/keyboard_shortcuts.hbs b/web/templates/keyboard_shortcuts.hbs index 15636e75cf..330e401b5e 100644 --- a/web/templates/keyboard_shortcuts.hbs +++ b/web/templates/keyboard_shortcuts.hbs @@ -66,7 +66,7 @@ {{t 'Go to your home view' }} - Ctrl + [ or Esc + Ctrl + [ or Esc diff --git a/web/tests/dispatch.test.cjs b/web/tests/dispatch.test.cjs index 15c6847160..a3c9369c80 100644 --- a/web/tests/dispatch.test.cjs +++ b/web/tests/dispatch.test.cjs @@ -1170,7 +1170,7 @@ run_test("user_settings", ({override}) => { event = event_fixtures.user_settings__web_escape_navigates_to_home_view; override(user_settings, "web_escape_navigates_to_home_view", false); let toggled = []; - $("#go-to-home-view-hotkey-help").toggleClass = (cls) => { + $("#keyboard-shortcuts .go-to-home-view-hotkey-help").toggleClass = (cls) => { toggled.push(cls); }; dispatch(event);