paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 15:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

push_notification: Remove 'content_truncated' field from FCM payload.

Browse Source 
This commit removes the 'content_truncated' field from the FCM
payload to send push notification as it was unused by clients.
This commit is contained in:
Prakhar Pratyush
2025-08-04 11:32:31 +05:30
committed by Tim Abbott
parent c9edb9c9ce
commit dd134ef325
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api_docs/changelog.md
View File

@@ -28,6 +28,8 @@ format used by the Zulip server that they are interacting with.
notifications no longer contain the legacy pre-2019 notifications no longer contain the legacy pre-2019
`zulip_message_id` field; all functional clients support the newer `zulip_message_id` field; all functional clients support the newer
`zulip_message_ids`. `zulip_message_ids`.
* Mobile push notification payloads for FCM to for new messages no
longer contain the (unused) `content_truncated` boolean field.
**Feature level 412** **Feature level 412**

3
zerver/lib/push_notifications.py
View File

@@ -1180,13 +1180,12 @@ def get_message_payload_gcm(
assert message.rendered_content is not None assert message.rendered_content is not None
with override_language(user_profile.default_language): with override_language(user_profile.default_language):
content, truncated = truncate_content(get_mobile_push_content(message.rendered_content)) content, unused = truncate_content(get_mobile_push_content(message.rendered_content))
data.update( data.update(
event="message", event="message",
zulip_message_id=message.id, # message_id is reserved for CCS zulip_message_id=message.id, # message_id is reserved for CCS
time=datetime_to_timestamp(message.date_sent), time=datetime_to_timestamp(message.date_sent),
content=content, content=content,
content_truncated=truncated,
sender_full_name=sender_name, sender_full_name=sender_name,
sender_avatar_url=sender_avatar_url, sender_avatar_url=sender_avatar_url,
) )

4
zerver/tests/test_push_notifications.py
View File

@@ -784,7 +784,6 @@ class PushBouncerNotificationTest(BouncerTestCase):
"zulip_message_id": message.id, "zulip_message_id": message.id,
"time": datetime_to_timestamp(message.date_sent), "time": datetime_to_timestamp(message.date_sent),
"content": message.content, "content": message.content,
"content_truncated": False,
"server": settings.EXTERNAL_HOST, "server": settings.EXTERNAL_HOST,
"realm_id": hamlet.realm.id, "realm_id": hamlet.realm.id,
"realm_uri": hamlet.realm.url, "realm_uri": hamlet.realm.url,
@@ -1816,7 +1815,6 @@ class TestGetGCMPayload(PushNotificationTestCase):
"zulip_message_id": message.id, "zulip_message_id": message.id,
"time": datetime_to_timestamp(message.date_sent), "time": datetime_to_timestamp(message.date_sent),
"content": content, "content": content,
"content_truncated": truncate_content,
"server": settings.EXTERNAL_HOST, "server": settings.EXTERNAL_HOST,
"realm_id": hamlet.realm.id, "realm_id": hamlet.realm.id,
"realm_name": hamlet.realm.name, "realm_name": hamlet.realm.name,
@@ -1879,7 +1877,6 @@ class TestGetGCMPayload(PushNotificationTestCase):
"zulip_message_id": message.id, "zulip_message_id": message.id,
"time": datetime_to_timestamp(message.date_sent), "time": datetime_to_timestamp(message.date_sent),
"content": message.content, "content": message.content,
"content_truncated": False,
"server": settings.EXTERNAL_HOST, "server": settings.EXTERNAL_HOST,
"realm_id": hamlet.realm.id, "realm_id": hamlet.realm.id,
"realm_name": hamlet.realm.name, "realm_name": hamlet.realm.name,
@@ -1927,7 +1924,6 @@ class TestGetGCMPayload(PushNotificationTestCase):
"zulip_message_id": message.id, "zulip_message_id": message.id,
"time": datetime_to_timestamp(message.date_sent), "time": datetime_to_timestamp(message.date_sent),
"content": message.content, "content": message.content,
"content_truncated": False,
"server": settings.EXTERNAL_HOST, "server": settings.EXTERNAL_HOST,
"realm_id": hamlet.realm.id, "realm_id": hamlet.realm.id,
"realm_name": hamlet.realm.name, "realm_name": hamlet.realm.name,