From ddb965110fc6e8a1215ef4a59ab6420cc7b84ab5 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Mon, 4 Mar 2019 14:47:17 -0800 Subject: [PATCH] CSS: Remove manual antialiasing configuration. The antialiasing decisions we made for the webapp should be constant over the entire page, not limited to particular subsections or themes. If we wanted antialiasing, we should do it on the entire page, not individual random widgets. But it's not clear we actually want to do it on the entire page. The `-moz-osx-font-smoothing: grayscale` setting now happens by default in OSX Mojave (40% world market share right now and growing), so there's no reason to override it. And without retina displays, generally, subpixel rendering provides better results than antialiasing (which overrides subpixel rendering). Thanks to Anders Kaseorg for advice on this issue. --- static/icons/fonts/template.hbs | 3 --- static/styles/alerts.scss | 2 -- static/styles/compose.scss | 2 -- static/styles/drafts.scss | 5 ----- static/styles/hotspots.scss | 2 -- static/styles/left-sidebar.scss | 3 --- static/styles/lightbox.scss | 3 --- static/styles/night_mode.scss | 1 - static/styles/portico.scss | 4 ---- static/styles/right-sidebar.scss | 1 - static/styles/settings.scss | 6 ------ static/styles/stats.scss | 2 -- static/styles/subscriptions.scss | 5 ----- static/styles/zulip.scss | 11 ----------- templates/zerver/emails/email.css | 1 - version.py | 2 +- 16 files changed, 1 insertion(+), 52 deletions(-) diff --git a/static/icons/fonts/template.hbs b/static/icons/fonts/template.hbs index 577fa8e9c6..4f9fd07693 100644 --- a/static/icons/fonts/template.hbs +++ b/static/icons/fonts/template.hbs @@ -20,9 +20,6 @@ i{{baseSelector}} { text-rendering: auto; display: inline-block; speak: none; - - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; } {{baseSelector}}::before { diff --git a/static/styles/alerts.scss b/static/styles/alerts.scss index 6d55f24c83..566c37339d 100644 --- a/static/styles/alerts.scss +++ b/static/styles/alerts.scss @@ -23,8 +23,6 @@ width: 900px; margin-left: calc(50% - 450px); z-index: 220; - - -webkit-font-smoothing: antialiased; } .alert-box .alert.show { diff --git a/static/styles/compose.scss b/static/styles/compose.scss index 0083f0e50a..5d80b9eb0a 100644 --- a/static/styles/compose.scss +++ b/static/styles/compose.scss @@ -169,8 +169,6 @@ table.compose_table { width: 100%; max-width: 1400px; margin: auto; - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; } .compose-content { diff --git a/static/styles/drafts.scss b/static/styles/drafts.scss index a0abde5cc9..36282d34a2 100644 --- a/static/styles/drafts.scss +++ b/static/styles/drafts.scss @@ -1,6 +1,3 @@ -.drafts { - -webkit-font-smoothing: antialiased; -} .drafts-container { position: relative; @@ -61,7 +58,6 @@ font-size: 1.5em; color: hsl(0, 0%, 67%); pointer-events: none; - -webkit-font-smoothing: antialiased; } .drafts-list .removed-drafts { @@ -70,7 +66,6 @@ font-size: 1em; color: hsl(0, 0%, 67%); pointer-events: none; - -webkit-font-smoothing: antialiased; } .draft-row { diff --git a/static/styles/hotspots.scss b/static/styles/hotspots.scss index 6bbe8ef762..aa25e70d22 100644 --- a/static/styles/hotspots.scss +++ b/static/styles/hotspots.scss @@ -74,8 +74,6 @@ .hotspot.overlay { z-index: 104; background-color: hsla(191, 7%, 20%, 0.15); - - -webkit-font-smoothing: antialiased; } .hotspot.overlay .hotspot-popover { diff --git a/static/styles/left-sidebar.scss b/static/styles/left-sidebar.scss index fd25286dd5..4ce93c46af 100644 --- a/static/styles/left-sidebar.scss +++ b/static/styles/left-sidebar.scss @@ -3,9 +3,6 @@ } #left-sidebar { - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; - font-size: 0.89rem; } diff --git a/static/styles/lightbox.scss b/static/styles/lightbox.scss index eed4d3903a..16c4e8e132 100644 --- a/static/styles/lightbox.scss +++ b/static/styles/lightbox.scss @@ -1,8 +1,5 @@ #lightbox_overlay { background-color: hsl(227, 40%, 16%); - - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; } #lightbox_overlay .image-preview { diff --git a/static/styles/night_mode.scss b/static/styles/night_mode.scss index ef76263851..de80d27a36 100644 --- a/static/styles/night_mode.scss +++ b/static/styles/night_mode.scss @@ -1,7 +1,6 @@ body.night-mode { background-color: hsl(212, 28%, 18%); color: hsl(236, 33%, 90%); - -webkit-font-smoothing: antialiased; .app-main, .header-main, diff --git a/static/styles/portico.scss b/static/styles/portico.scss index 07d696931f..b06af58f85 100644 --- a/static/styles/portico.scss +++ b/static/styles/portico.scss @@ -249,8 +249,6 @@ body { font: normal normal normal 14px/1 FontAwesome; font-size: inherit; text-rendering: auto; - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; content: "\f107"; margin-right: 5px; @@ -269,8 +267,6 @@ body { font: normal normal normal 14px/1 FontAwesome; font-size: inherit; text-rendering: auto; - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; content: "\f0d9"; margin-right: 10px; diff --git a/static/styles/right-sidebar.scss b/static/styles/right-sidebar.scss index 34a7c97adb..bbf3ed32cf 100644 --- a/static/styles/right-sidebar.scss +++ b/static/styles/right-sidebar.scss @@ -1,5 +1,4 @@ .right-sidebar { - -webkit-font-smoothing: antialiased; font-size: 0.89rem; } diff --git a/static/styles/settings.scss b/static/styles/settings.scss index 080da8236b..00d6351aee 100644 --- a/static/styles/settings.scss +++ b/static/styles/settings.scss @@ -1241,10 +1241,6 @@ input[type=checkbox].inline-block { margin: 2.5vh auto; overflow: hidden; border-radius: 4px; - - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; - transition: transform 0.2s ease; } @@ -1349,8 +1345,6 @@ input[type=checkbox].inline-block { font: normal normal normal 12px/1 FontAwesome; font-size: inherit; text-rendering: auto; - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; } #settings_page .table-striped thead th.active.descend::after { diff --git a/static/styles/stats.scss b/static/styles/stats.scss index 9bb20ca293..d2a6e9aa65 100644 --- a/static/styles/stats.scss +++ b/static/styles/stats.scss @@ -7,8 +7,6 @@ body { font-family: 'Source Sans Pro', 'Helvetica Neue', sans-serif !important; background-color: hsl(0, 0%, 98%); - - -webkit-font-smoothing: antialiased; } p { diff --git a/static/styles/subscriptions.scss b/static/styles/subscriptions.scss index ff6a2c12f6..d19ccf2644 100644 --- a/static/styles/subscriptions.scss +++ b/static/styles/subscriptions.scss @@ -34,10 +34,6 @@ vertical-align: middle; } -.subscriptions { - -webkit-font-smoothing: antialiased; -} - .subscriptions div #response { overflow-wrap: break-word; } @@ -462,7 +458,6 @@ form#add_new_subscription { margin-top: calc(45vh - 75px); text-align: center; font-size: 1em; - -webkit-font-smoothing: antialiased; } .subscriptions-container .right .nothing-selected span { diff --git a/static/styles/zulip.scss b/static/styles/zulip.scss index f9d754820b..170dfe5cb0 100644 --- a/static/styles/zulip.scss +++ b/static/styles/zulip.scss @@ -197,8 +197,6 @@ p.n-margin { } #panels { - -webkit-font-smoothing: antialiased; - font-size: 1rem; } @@ -2450,11 +2448,6 @@ div.topic_edit_spinner .loading_indicator_spinner { margin-bottom: 0px; } -#invite-user { - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; -} - #invite-user .modal-header { padding: 7px 15px; border-color: hsl(0, 0%, 87%); @@ -2838,10 +2831,6 @@ div.topic_edit_spinner .loading_indicator_spinner { height: 80px; padding: 5px; z-index: 1; - - -moz-osx-font-smoothing: grayscale; - font-smoothing: antialiased; - -webkit-font-smoothing: antialiased; text-shadow: rgba(0, 0, 0, .01) 0 0 1px; } diff --git a/templates/zerver/emails/email.css b/templates/zerver/emails/email.css index e9dae264aa..ab738974e3 100644 --- a/templates/zerver/emails/email.css +++ b/templates/zerver/emails/email.css @@ -13,7 +13,6 @@ img { body { background-color: #f5f9f8; font-family: sans-serif; - -webkit-font-smoothing: antialiased; font-size: 14px; line-height: 1.4; margin: 0; diff --git a/version.py b/version.py index 4bf4c6f880..7d247bcf20 100644 --- a/version.py +++ b/version.py @@ -11,4 +11,4 @@ LATEST_RELEASE_ANNOUNCEMENT = "https://blog.zulip.org/2019/03/01/zulip-2-0-relea # Typically, adding a dependency only requires a minor version bump, and # removing a dependency requires a major version bump. -PROVISION_VERSION = '28.6' +PROVISION_VERSION = '28.7'