paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-31 03:53:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

typing_notifications: Do op validation in view function.

Browse Source 
Instead of validating `op` value later, this commit does that
in `REQ`.

Also helps avoiding duplication of this validation when
stream typing notifications feature is added.
This commit is contained in:
Dinesh
2021-02-06 00:02:46 +05:30
committed by Tim Abbott
parent 2d40224bb6
commit ddca602123
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/lib/actions.py
View File

@@ -2238,8 +2238,6 @@ def check_send_typing_notification(sender: UserProfile, user_ids: List[int], ope
realm = sender.realm
if len(user_ids) == 0:
raise JsonableError(_("Missing parameter: 'to' (recipient)"))
elif operator not in ("start", "stop"):
raise JsonableError(_("Invalid 'op' value (should be start or stop)"))
""" The next chunk of code will go away when we upgrade old mobile
users away from versions of mobile that send emails. For the