paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 15:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

actions: Convert do_delete_messages to take a Realm.

Browse Source 
The function only used the user's realm anyway, so this is a cleaner
API.

This should also make it more convenient to permanently delete
messages manually, since one doesn't have to fetch a random user in
the realm in order to delete a message using the management shell.

No functional change.
This commit is contained in:
Tim Abbott
2019-11-12 12:20:31 -08:00
parent 6945ced76f
commit ddd1a0eb00
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/lib/actions.py
View File

@@ -4564,7 +4564,7 @@ def do_update_message(user_profile: UserProfile, message: Message, topic_name: O
return len(changed_messages)
def do_delete_messages(user_profile: UserProfile, messages: Iterable[Message]) -> None:
def do_delete_messages(realm: Realm, messages: Iterable[Message]) -> None:
message_ids = []
for message in messages:
message_ids.append(message.id)
@@ -4590,7 +4590,7 @@ def do_delete_messages(user_profile: UserProfile, messages: Iterable[Message]) -
ums = [{'id': um.user_profile_id} for um in
UserMessage.objects.filter(message=message.id)]
move_messages_to_archive([message.id])
send_event(user_profile.realm, event, ums)
send_event(realm, event, ums)
def do_delete_messages_by_sender(user: UserProfile) -> None:
message_ids = Message.objects.filter(sender=user).values_list('id', flat=True).order_by('id')