paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Use HTML table for "Alert Words" for better icon alignment.

Browse Source 
"Alert Words" is one of Zulip's oldest settings UI elements, and as a
result is buggy.  This commit converts it to use our standard
progressive-table-wrapper system used for settings tables, which has
the side effect of fixing a bug that mad ethe tables look pretty bad
if one adds a very long word.

Fixes #17172.
This commit is contained in:
Josh Gilley
2021-02-01 19:35:51 -05:00
committed by Tim Abbott
parent 28d437672f
commit de74d2fd7c
5 changed files with 23 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend_tests/node_tests/alert_words_ui.js
View File

@@ -136,11 +136,11 @@ run_test("remove_alert_word", (override) => {
const remove_func = word_list.get_on_handler("click", ".remove-alert-word");
const remove_alert_word = $(".remove-alert-word");
const list_item = $("li.alert-word-item");
const list_item = $("tr.alert-word-item");
const val_item = $("span.value");
val_item.text(i18n.t("zot"));
remove_alert_word.set_parents_result("li", list_item);
remove_alert_word.set_parents_result("tr", list_item);
list_item.set_find_results(".value", val_item);
const event = {