paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

notifications_data: Rename id -> user_id.

Browse Source 
We also make this a mandatory named argument for our test helper
for clarity.
This commit is contained in:
Abhijeet Prasad Bodas
2021-06-23 14:14:34 +05:30
parent f6e705d477
commit dedc39f139
6 changed files with 45 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/lib/notification_data.py
View File

@@ -4,7 +4,7 @@ from typing import Collection, Set
@dataclass
class UserMessageNotificationsData:
id: int
user_id: int
flags: Collection[str]
mentioned: bool
online_push_enabled: bool
@@ -34,7 +34,7 @@ class UserMessageNotificationsData:
user_id in wildcard_mention_user_ids and "wildcard_mentioned" in flags
)
return cls(
id=user_id,
user_id=user_id,
flags=flags,
mentioned=("mentioned" in flags),
online_push_enabled=(user_id in online_push_user_ids),
@@ -57,7 +57,7 @@ class UserMessageNotificationsData:
if not idle and not self.online_push_enabled:
return False
if self.id == sender_id:
if self.user_id == sender_id:
return False
if self.sender_is_muted:
@@ -74,7 +74,7 @@ class UserMessageNotificationsData:
if not idle:
return False
if self.id == sender_id:
if self.user_id == sender_id:
return False
if self.sender_is_muted: