paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 21:48:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

default_language_modal: Add more space around languages displayed.

Browse Source 
We use 3 columns on wide screens and come down to 1 column on
narrow screens to ensure that the languages are properly
displayed.
This commit is contained in:
Aman Agrawal
2022-06-06 13:38:17 +00:00
committed by Tim Abbott
parent 084b054827
commit df6ad8154a
4 changed files with 70 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
frontend_tests/node_tests/i18n.js
View File

@@ -146,54 +146,34 @@ run_test("language_list", () => {
const successful_formatted_list = [
{
first: {
name: "English",
code: "en",
name_with_percent: "English",
selected: true,
},
second: {
name: "Bahasa Indonesia",
code: "id",
name_with_percent: "Bahasa Indonesia (32%)",
selected: false,
},
name: "English",
code: "en",
name_with_percent: "English",
selected: true,
},
{
first: {
name: "British English",
code: "en-gb",
name_with_percent: "British English (99%)",
selected: false,
},
name: "British English",
code: "en-gb",
name_with_percent: "British English (99%)",
selected: false,
},
{
name: "Bahasa Indonesia",
code: "id",
name_with_percent: "Bahasa Indonesia (32%)",
selected: false,
},
];
const formatted_list = get_language_list_columns("en");
function check_value_match(element, position) {
assert.equal(
formatted_list[element][position].name,
successful_formatted_list[element][position].name,
);
assert.equal(
formatted_list[element][position].code,
successful_formatted_list[element][position].code,
);
assert.equal(
formatted_list[element][position].name_with_percent,
successful_formatted_list[element][position].name_with_percent,
);
assert.equal(
formatted_list[element][position].selected,
successful_formatted_list[element][position].selected,
);
}
for (const element of _.range(0, formatted_list.length)) {
check_value_match(element, "first");
if (formatted_list[element].second) {
check_value_match(element, "second");
}
assert.equal(formatted_list[element].name, successful_formatted_list[element].name);
assert.equal(formatted_list[element].code, successful_formatted_list[element].code);
assert.equal(
formatted_list[element].name_with_percent,
successful_formatted_list[element].name_with_percent,
);
assert.equal(formatted_list[element].selected, successful_formatted_list[element].selected);
}
});