paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 18:06:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

lint: Start to deprecate "subject" references.

Browse Source
This commit is contained in:
Steve Howell
2018-11-01 20:21:01 +00:00
committed by Tim Abbott
parent af1acf9239
commit df743e8948
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tools/linter_lib/custom_check.py
View File

@@ -272,6 +272,11 @@ def build_custom_checkers(by_lang):
'bad_lines': ['<p style="color: blue;">Foo</p>', 'style = "color: blue;"']}, 'bad_lines': ['<p style="color: blue;">Foo</p>', 'style = "color: blue;"']},
]) + whitespace_rules + comma_whitespace_rule ]) + whitespace_rules + comma_whitespace_rule
python_rules = cast(RuleList, [ python_rules = cast(RuleList, [
{'pattern': 'subject|SUBJECT',
'description': 'avoid subject as a var',
'good_lines': ['topic_name'],
'bad_lines': ['subject="foo"', ' MAX_SUBJECT_LEN'],
'include_only': set(['zerver/lib/actions.py'])},
{'pattern': '^(?!#)@login_required', {'pattern': '^(?!#)@login_required',
'description': '@login_required is unsupported; use @zulip_login_required', 'description': '@login_required is unsupported; use @zulip_login_required',
'good_lines': ['@zulip_login_required', '# foo @login_required'], 'good_lines': ['@zulip_login_required', '# foo @login_required'],