paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 17:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

do_delete_user: Make the replacement dummy user inactive.

Browse Source 
Otherwise, the dummy user will show up in the user list in the right
sidebar.
This commit is contained in:
Mateusz Mandera
2021-10-05 21:56:37 +02:00
committed by Tim Abbott
parent fc13dd6f3d
commit dffdeb48e7
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
zerver/lib/actions.py
View File

@@ -1228,6 +1228,7 @@ def do_delete_user(user_profile: UserProfile) -> None:
password=None, password=None,
realm=realm, realm=realm,
full_name=f"Deleted User {user_id}", full_name=f"Deleted User {user_id}",
active=False,
is_mirror_dummy=True, is_mirror_dummy=True,
) )
subs_to_recreate = [ subs_to_recreate = [

1
zerver/tests/test_users.py
View File

@@ -2071,6 +2071,7 @@ class DeleteUserTest(ZulipTestCase):
replacement_dummy_user.delivery_email, f"deleteduser{hamlet_user_id}@{realm.uri}" replacement_dummy_user.delivery_email, f"deleteduser{hamlet_user_id}@{realm.uri}"
) )
self.assertEqual(replacement_dummy_user.is_mirror_dummy, True) self.assertEqual(replacement_dummy_user.is_mirror_dummy, True)
self.assertEqual(replacement_dummy_user.is_active, False)
self.assertEqual(Message.objects.filter(id__in=personal_message_ids_to_hamlet).count(), 0) self.assertEqual(Message.objects.filter(id__in=personal_message_ids_to_hamlet).count(), 0)
# Huddle messages from hamlet should have been deleted, but messages of other participants should # Huddle messages from hamlet should have been deleted, but messages of other participants should