paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-21 15:09:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

dialog_widget: Fix race focusing submit button.

Browse Source 
Opening the modal before adding the on_shown handler makes it possible
that the modal could full appear before the handler runs.
This commit is contained in:
Tim Abbott
2021-07-14 13:13:43 -07:00
parent 6fb0d414b4
commit e0135e278d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/dialog_widget.js
View File

@@ -131,12 +131,12 @@ export function launch(conf) {
dialog.remove(); dialog.remove();
}); });
// Open the modal
overlays.open_modal("#dialog_widget_modal");
if (conf.focus_submit_on_open) { if (conf.focus_submit_on_open) {
conf.parent.on("shown.bs.modal", () => { conf.parent.on("shown.bs.modal", () => {
submit_button.trigger("focus"); submit_button.trigger("focus");
}); });
} }
// Open the modal
overlays.open_modal("#dialog_widget_modal");
} }