paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 00:18:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

home: Ignore handlebars errors in the test suite.

Browse Source 
The handlebars error message is just for the manual development
environment; this prevents the state of compiling handlebars templates
from run-dev.py from potentially causing the unit tests to fail.
This commit is contained in:
Tim Abbott
2018-04-28 13:46:59 -07:00
parent 7d6bb3dcb4
commit e087be6630
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/tests/test_home.py
View File

@@ -612,7 +612,7 @@ class HomeTest(ZulipTestCase):
def test_handlebars_compile_error(self) -> None: def test_handlebars_compile_error(self) -> None:
request = HostRequestMock() request = HostRequestMock()
with self.settings(DEVELOPMENT=True): with self.settings(DEVELOPMENT=True, TEST_SUITE=False):
with patch('os.path.exists', return_value=True): with patch('os.path.exists', return_value=True):
result = home(request) result = home(request)
self.assertEqual(result.status_code, 500) self.assertEqual(result.status_code, 500)

3
zerver/views/home.py
View File

@@ -75,7 +75,8 @@ def get_bot_types(user_profile: UserProfile) -> List[Dict[str, object]]:
return bot_types return bot_types
def home(request: HttpRequest) -> HttpResponse: def home(request: HttpRequest) -> HttpResponse:
if settings.DEVELOPMENT and os.path.exists('var/handlebars-templates/compile.error'): if (settings.DEVELOPMENT and not settings.TEST_SUITE and
os.path.exists('var/handlebars-templates/compile.error')):
response = render(request, 'zerver/handlebars_compilation_failed.html') response = render(request, 'zerver/handlebars_compilation_failed.html')
response.status_code = 500 response.status_code = 500
return response return response