paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

webhooks: Migrate to UnexpectedWebhookEventType.

Browse Source 
This improves test coverage for a lot of our webhooks that relied
on ad-hoc methods to handle unexpected event types.

Note that I have deliberately skipped github_legacy, it isn't
advertised and is officially deprecated.

Also, I have refrained from making further changes to Trello, I
believe further improvements to test coverage should be covered
in separate per-webhook commits/PRs.
This commit is contained in:
Eeshan Garg
2018-05-22 12:16:45 -02:30
committed by Tim Abbott
parent 3ed20589f2
commit e0ef831993
15 changed files with 40 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tools/test-backend
View File

@@ -97,30 +97,23 @@ not_yet_fully_covered = {
# Experimenatal
'zerver/lib/widget.py',
# Webhook integrations with incomplete coverage
'zerver/webhooks/basecamp/view.py',
'zerver/webhooks/beanstalk/view.py',
'zerver/webhooks/bitbucket2/view.py',
'zerver/webhooks/freshdesk/view.py',
'zerver/webhooks/github_legacy/view.py',
'zerver/webhooks/github/view.py',
'zerver/webhooks/github_legacy/view.py',
'zerver/webhooks/gitlab/view.py',
'zerver/webhooks/gogs/view.py',
'zerver/webhooks/greenhouse/view.py',
'zerver/webhooks/hellosign/view.py',
'zerver/webhooks/ifttt/view.py',
'zerver/webhooks/jira/view.py',
'zerver/webhooks/librato/view.py',
'zerver/webhooks/newrelic/view.py',
'zerver/webhooks/pingdom/view.py',
'zerver/webhooks/pivotal/view.py',
'zerver/webhooks/semaphore/view.py',
'zerver/webhooks/solano/view.py',
'zerver/webhooks/stripe/view.py',
'zerver/webhooks/taiga/view.py',
'zerver/webhooks/teamcity/view.py',
'zerver/webhooks/transifex/view.py',
'zerver/webhooks/travis/view.py',
'zerver/webhooks/updown/view.py',
'zerver/webhooks/zapier/view.py',
}