paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-21 23:19:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

recent: Don't modify row_focus if table is not focused.

Browse Source 
This fixes an error in the `inplace_rerender` code when we
are trying to remove a rendered row and correcting the `row_focus`
if it is on the row being removed. If the table is not in focus,
we don't need to do anything.
This commit is contained in:
Aman Agrawal
2022-11-18 02:55:31 +00:00
committed by Tim Abbott
parent ac8de664e8
commit e11b0171fa
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/recent_topics_ui.js
View File

@@ -568,7 +568,14 @@ export function inplace_rerender(topic_key) {
topics_widget.filter_and_sort(); topics_widget.filter_and_sort();
const current_topics_list = topics_widget.get_current_list(); const current_topics_list = topics_widget.get_current_list();
if (is_topic_rendered && filters_should_hide_topic(topic_data)) { if (is_topic_rendered && filters_should_hide_topic(topic_data)) {
const row_is_focused = get_focused_row_message().id === topic_data.last_msg_id; // Since the row needs to be removed from DOM, we need to adjust `row_focus`
// if the row being removed is focused and is the last row in the list.
// This prevents the row_focus either being reset to the first row or
// middle of the visible table rows.
// We need to get the current focused row details from DOM since we cannot
// rely on `current_topics_list` since it has already been updated and row
// doesn't exist inside it.
const row_is_focused = get_focused_row_message()?.id === topic_data.last_msg_id;
if (row_is_focused && row_focus >= current_topics_list.length) { if (row_is_focused && row_focus >= current_topics_list.length) {
row_focus = current_topics_list.length - 1; row_focus = current_topics_list.length - 1;
} }