From e123f8f7235ca68be4c1ff70f4aed7df3cc89d03 Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Thu, 23 Jul 2020 00:10:06 -0700 Subject: [PATCH] subs: Fix set_muted parameter order. The status_element parameter is optional, and the other caller in stream_popover.js does not provide it. This fixes a regression in commit e6a66063a9d89bab84f754d27b3e8683c364b29f (#15868). Signed-off-by: Anders Kaseorg --- static/js/stream_edit.js | 2 +- static/js/subs.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/static/js/stream_edit.js b/static/js/stream_edit.js index 553bcbe886..918ae8f146 100644 --- a/static/js/stream_edit.js +++ b/static/js/stream_edit.js @@ -413,7 +413,7 @@ function stream_is_muted_changed(e) { const sub_settings = exports.settings_for_sub(sub); const notification_checkboxes = sub_settings.find(".sub_notification_setting"); - subs.set_muted(sub, `#stream_change_property_status${sub.stream_id}`, e.target.checked); + subs.set_muted(sub, e.target.checked, `#stream_change_property_status${sub.stream_id}`); sub_settings.find(".mute-note").toggleClass("hide-mute-note", !sub.is_muted); notification_checkboxes.toggleClass("muted-sub", sub.is_muted); notification_checkboxes.find("input[type='checkbox']").prop("disabled", sub.is_muted); diff --git a/static/js/subs.js b/static/js/subs.js index a15f283954..8e49ce8a37 100644 --- a/static/js/subs.js +++ b/static/js/subs.js @@ -95,7 +95,7 @@ exports.active_stream = function () { } }; -exports.set_muted = function (sub, status_element, is_muted) { +exports.set_muted = function (sub, is_muted, status_element) { stream_muting.update_is_muted(sub, is_muted); stream_edit.set_stream_property(sub, "is_muted", sub.is_muted, status_element); };