tools: Upgrade Pycodestyle and fix new linter errors.

Here, we are upgrading pycodestyle version from 2.4.0 to 2.5.0.

Fixes: #11396.

requirements/dev.in

@@ -26,7 +26,7 @@ httpretty==0.9.6
 isort==4.3.4
 
 # for pep8 linter
-pycodestyle==2.4.0
+pycodestyle==2.5.0
 
 # Needed to run pyflakes linter
 pyflakes==2.0.0

requirements/dev.txt

@@ -121,7 +121,7 @@ py3dns==3.2.0
 pyaml==18.11.0            # via moto
 pyasn1-modules==0.2.4
 pyasn1==0.4.5
-pycodestyle==2.4.0
+pycodestyle==2.5.0
 pycparser==2.19           # via cffi
 pycrypto==2.6.1
 pycryptodome==3.7.3       # via python-jose

version.py

@@ -11,4 +11,4 @@ LATEST_RELEASE_ANNOUNCEMENT = "https://blog.zulip.org/2018/11/07/zulip-1-9-relea
 # Typically, adding a dependency only requires a minor version bump, and
 # removing a dependency requires a major version bump.
 
-PROVISION_VERSION = '27.4'
+PROVISION_VERSION = '27.5'

zerver/data_import/slack.py

@@ -44,7 +44,7 @@ def rm_tree(path: str) -> None:
 
 def slack_workspace_to_realm(domain_name: str, realm_id: int, user_list: List[ZerverFieldsT],
                              realm_subdomain: str, slack_data_dir: str,
-                             custom_emoji_list: ZerverFieldsT)-> Tuple[ZerverFieldsT, AddedUsersT,
+                             custom_emoji_list: ZerverFieldsT) -> Tuple[ZerverFieldsT, AddedUsersT,
                                                                         AddedRecipientsT,
                                                                         AddedChannelsT,
                                                                         List[ZerverFieldsT],

zerver/lib/test_classes.py

@@ -720,7 +720,7 @@ class WebhookTestCase(ZulipTestCase):
 
     def send_and_test_private_message(self, fixture_name: str, expected_topic: str=None,
                                       expected_message: str=None, content_type: str="application/json",
-                                      **kwargs: Any)-> Message:
+                                      **kwargs: Any) -> Message:
         payload = self.get_body(fixture_name)
         if content_type is not None:
             kwargs['content_type'] = content_type

zerver/tests/test_messages.py

@@ -1820,7 +1820,7 @@ class MessagePOSTTest(ZulipTestCase):
         # to ANY stream, even one she is not unsubscribed to, and
         # she can do it for herself or on behalf of a mirrored user.
 
-        def test_with(sender_email: str, client: str, forged: bool) ->None:
+        def test_with(sender_email: str, client: str, forged: bool) -> None:
             payload = dict(
                 type="stream",
                 to=stream_name,

zerver/tests/test_webhooks_common.py

@@ -50,7 +50,7 @@ class WebhooksCommonTestCase(ZulipTestCase):
         self.assertEqual(msg.sender.email, notification_bot.email)
         self.assertEqual(msg.content, expected_message)
 
-    def test_notify_bot_owner_on_invalid_json(self)-> None:
+    def test_notify_bot_owner_on_invalid_json(self) -> None:
         @api_key_only_webhook_view('ClientName', notify_bot_owner_on_invalid_json=False)
         def my_webhook_no_notify(request: HttpRequest, user_profile: UserProfile) -> None:
             raise InvalidJSONError("Malformed JSON")

zerver/webhooks/newrelic/view.py

@@ -17,7 +17,7 @@ from zerver.models import Stream, UserProfile
 def api_newrelic_webhook(request: HttpRequest, user_profile: UserProfile,
                          alert: Optional[Dict[str, Any]]=REQ(validator=check_dict([]), default=None),
                          deployment: Optional[Dict[str, Any]]=REQ(validator=check_dict([]), default=None)
-                         )-> HttpResponse:
+                         ) -> HttpResponse:
     if alert:
         # Use the message as the subject because it stays the same for
         # "opened", "acknowledged", and "closed" messages that should be