paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

emoji_codes: Replace JS module with JSON module.

Browse Source 
webpack optimizes JSON modules using JSON.parse("{…}"), which is
faster than the normal JavaScript parser.

Update the backend to use emoji_codes.json too instead of the three
separate JSON files.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2020-02-05 22:07:10 -08:00
committed by Tim Abbott
parent dce7118ec7
commit e257253e64
21 changed files with 49 additions and 128 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
frontend_tests/node_tests/emoji.js
View File

@@ -6,7 +6,7 @@ set_global('page_params', {
set_global('upload_widget', {});
set_global('blueslip', global.make_zblueslip());
set_global('emoji_codes', zrequire('emoji_codes', 'generated/emoji/emoji_codes'));
const emoji_codes = zrequire('emoji_codes', 'generated/emoji/emoji_codes.json');
zrequire('emoji');
zrequire('markdown');
zrequire('util');
@@ -68,29 +68,19 @@ run_test('get_canonical_name', () => {
let canonical_name = emoji.get_canonical_name('realm_emoji');
assert.equal(canonical_name, 'realm_emoji');
const orig_emoji_codes = global.emoji_codes;
global.emoji_codes = {
name_to_codepoint: {
'+1': '1f44d',
},
codepoint_to_name: {
'1f44d': 'thumbs_up',
},
};
canonical_name = emoji.get_canonical_name('+1');
assert.equal(canonical_name, 'thumbs_up');
canonical_name = emoji.get_canonical_name('thumbs_up');
assert.equal(canonical_name, '+1');
emoji.active_realm_emojis = new Map(Object.entries({
'+1': 'TBD',
}));
canonical_name = emoji.get_canonical_name('+1');
assert.equal(canonical_name, '+1');
canonical_name = emoji.get_canonical_name('airplane');
assert.equal(canonical_name, 'airplane');
blueslip.set_test_data('error', 'Invalid emoji name: non_existent');
emoji.get_canonical_name('non_existent');
assert.equal(blueslip.get_test_logs('error').length, 1);
blueslip.clear_test_data();
global.emoji_codes = orig_emoji_codes;
});
run_test('translate_emoticons_to_names', () => {