paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 16:37:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

js: Clean up poorly named const id variables.

Browse Source 
We have conventions for naming message_id, stream_id, etc. values that
way for readability; these entries are violations of those conventions.
This commit is contained in:
Tim Abbott
2020-01-16 13:27:27 -08:00
parent f13f744874
commit e2681372f3
4 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
static/js/stream_edit.js
View File

@@ -19,8 +19,7 @@ exports.setup_subscriptions_tab_hash = function (tab_key_value) {
};
exports.settings_for_sub = function (sub) {
const id = sub.stream_id;
return $("#subscription_overlay .subscription_settings[data-stream-id='" + id + "']");
return $("#subscription_overlay .subscription_settings[data-stream-id='" + sub.stream_id + "']");
};
exports.is_sub_settings_active = function (sub) {
@@ -96,8 +95,8 @@ function format_member_list_elem(email) {
}
function get_subscriber_list(sub_row) {
const id = sub_row.data("stream-id");
return $('.subscription_settings[data-stream-id="' + id + '"] .subscriber-list');
const stream_id_str = sub_row.data("stream-id");
return $('.subscription_settings[data-stream-id="' + stream_id_str + '"] .subscriber-list');
}
exports.update_stream_name = function (sub, new_name) {