paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

js: Clean up poorly named const id variables.

Browse Source 
We have conventions for naming message_id, stream_id, etc. values that
way for readability; these entries are violations of those conventions.
This commit is contained in:
Tim Abbott
2020-01-16 13:27:27 -08:00
parent f13f744874
commit e2681372f3
4 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/subs.js
View File

@@ -15,8 +15,7 @@ exports.show_subs_pane = {
};
exports.check_button_for_sub = function (sub) {
const id = sub.stream_id;
return $(".stream-row[data-stream-id='" + id + "'] .check");
return $(".stream-row[data-stream-id='" + sub.stream_id + "'] .check");
};
exports.row_for_stream_id = function (stream_id) {
@@ -26,8 +25,7 @@ exports.row_for_stream_id = function (stream_id) {
exports.settings_button_for_sub = function (sub) {
// We don't do expectOne() here, because this button is only
// visible if the user has that stream selected in the streams UI.
const id = sub.stream_id;
return $(".subscription_settings[data-stream-id='" + id + "'] .subscribe-button");
return $(".subscription_settings[data-stream-id='" + sub.stream_id + "'] .subscribe-button");
};
function get_row_data(row) {