paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 06:23:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

echo: Fix local echo sending a message to "yourself, ".

Browse Source 
Previously, this would incorrectly include a user with name and email
"" in the recipients list shown in the local echo code path.

We fix this and add a test for the issue.
This commit is contained in:
Tim Abbott
2016-11-14 21:40:19 -08:00
parent d655cd1f7f
commit e40e756d47
3 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
static/js/echo.js
View File

@@ -146,8 +146,11 @@ function insert_local_message(message_request, local_id) {
if (message.type === 'stream') {
message.display_recipient = message.stream;
} else {
// Build a display recipient with the full names of each recipient
var emails = message_request.private_message_recipient.split(',');
// Build a display recipient with the full names of each
// recipient. Note that it's important that use
// util.extract_pm_recipients, which filters out any spurious
// ", " at the end of the recipient list
var emails = util.extract_pm_recipients(message_request.private_message_recipient);
message.display_recipient = _.map(emails, function (email) {
email = email.trim();
var person = people.get_by_email(email);