paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

slack_message_conversion: Clean up type ignores.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2019-08-09 15:30:33 -07:00
parent 17acf95437
commit e417d3a040
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
zerver/data_import/slack_message_conversion.py
View File

@@ -115,8 +115,9 @@ def convert_to_zulip_markdown(text: str, users: List[ZerverFieldsT],
def get_user_mentions(token: str, users: List[ZerverFieldsT], def get_user_mentions(token: str, users: List[ZerverFieldsT],
added_users: AddedUsersT) -> Tuple[str, Optional[int]]: added_users: AddedUsersT) -> Tuple[str, Optional[int]]:
slack_usermention_match = re.search(SLACK_USERMENTION_REGEX, token, re.VERBOSE) slack_usermention_match = re.search(SLACK_USERMENTION_REGEX, token, re.VERBOSE)
short_name = slack_usermention_match.group(4) # type: ignore # slack_usermention_match exists and is not None assert slack_usermention_match is not None
slack_id = slack_usermention_match.group(2) # type: ignore # slack_usermention_match exists and is not None short_name = slack_usermention_match.group(4)
slack_id = slack_usermention_match.group(2)
for user in users: for user in users:
if (user['id'] == slack_id and user['name'] == short_name and short_name) or \ if (user['id'] == slack_id and user['name'] == short_name and short_name) or \
(user['id'] == slack_id and short_name is None): (user['id'] == slack_id and short_name is None):