paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_groups: Move constants for system group names to a new class.

Browse Source 
This commit moves constants for system group names to a new
"SystemGroups" class so that we can use these group names
in multiple classes in models.py without worrying about the
order of defining them.
This commit is contained in:
Sahil Batra
2023-09-21 16:36:39 +05:30
committed by Tim Abbott
parent 2c43c2a4db
commit e458b73a01
20 changed files with 128 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
zerver/lib/import_realm.py
View File

@@ -63,6 +63,7 @@ from zerver.models import (
Service,
Stream,
Subscription,
SystemGroups,
UserActivity,
UserActivityInterval,
UserGroup,
@@ -192,7 +193,7 @@ def fix_upload_links(data: TableData, message_table: TableName) -> None:
def fix_streams_can_remove_subscribers_group_column(data: TableData, realm: Realm) -> None:
table = get_db_table(Stream)
admins_group = UserGroup.objects.get(
name=UserGroup.ADMINISTRATORS_GROUP_NAME, realm=realm, is_system_group=True
name=SystemGroups.ADMINISTRATORS, realm=realm, is_system_group=True
)
for stream in data[table]:
stream["can_remove_subscribers_group"] = admins_group
@@ -1675,7 +1676,7 @@ def add_users_to_system_user_groups(
realm: Realm, user_profiles: List[UserProfile], role_system_groups_dict: Dict[int, UserGroup]
) -> None:
full_members_system_group = UserGroup.objects.get(
name=UserGroup.FULL_MEMBERS_GROUP_NAME,
name=SystemGroups.FULL_MEMBERS,
realm=realm,
is_system_group=True,
)