paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-15 19:31:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_store: Only allow number for message_id.

Browse Source
This commit is contained in:
evykassirer
2024-01-04 22:53:23 -08:00
committed by Tim Abbott
parent e986813943
commit e4ba07dcf2
2 changed files with 1 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/src/message_store.ts
View File

@@ -156,19 +156,6 @@ export function clear_for_testing(): void {
} }
export function get(message_id: number): Message | undefined { export function get(message_id: number): Message | undefined {
if (message_id === undefined || message_id === null) {
blueslip.error("message_store.get got bad value", {message_id});
return undefined;
}
if (typeof message_id !== "number") {
blueslip.error("message_store got non-number", {message_id});
// Try to soldier on, assuming the caller treats message
// ids as strings.
message_id = Number.parseFloat(message_id);
}
return stored_messages.get(message_id); return stored_messages.get(message_id);
} }

11
web/tests/message_store.test.js
View File

@@ -115,11 +115,7 @@ test("process_new_message", () => {
assert.equal(message.alerted, true); assert.equal(message.alerted, true);
assert.equal(message.is_me_message, false); assert.equal(message.is_me_message, false);
let retrieved_message = message_store.get(2067); const retrieved_message = message_store.get(2067);
assert.equal(retrieved_message, message);
blueslip.expect("error", "message_store got non-number");
retrieved_message = message_store.get("2067");
assert.equal(retrieved_message, message); assert.equal(retrieved_message, message);
// access cached previous message, and test match subject/content // access cached previous message, and test match subject/content
@@ -356,8 +352,3 @@ test("update_property", () => {
assert.equal(message2.stream_id, denmark.stream_id); assert.equal(message2.stream_id, denmark.stream_id);
assert.equal(message2.display_recipient, denmark.name); assert.equal(message2.display_recipient, denmark.name);
}); });
test("errors", () => {
blueslip.expect("error", "message_store.get got bad value");
message_store.get(undefined);
});