paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

narrow: Remove unnecessary select_first_unread option.

Browse Source 
We consistently either pass a `then_select_id` into narrow.activate,
or were using the select_first_unread option.  Now, we just compute
select_first_unread based on the value of then_select_id.
This commit is contained in:
Tim Abbott
2018-04-22 21:02:11 -07:00
parent 0c9b1dc9ff
commit e4c50ff4fd
14 changed files with 24 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/popovers.js
View File

@@ -585,7 +585,7 @@ exports.register_click_handlers = function () {
var user_id = $(e.target).parents('ul').attr('data-user-id');
var email = people.get_person_from_user_id(user_id).email;
popovers.hide_message_info_popover();
narrow.by('pm-with', email, {select_first_unread: true, trigger: 'user sidebar popover'});
narrow.by('pm-with', email, {trigger: 'user sidebar popover'});
e.stopPropagation();
e.preventDefault();
});
@@ -594,7 +594,7 @@ exports.register_click_handlers = function () {
var user_id = $(e.target).parents('ul').attr('data-user-id');
var email = people.get_person_from_user_id(user_id).email;
popovers.hide_message_info_popover();
narrow.by('sender', email, {select_first_unread: true, trigger: 'user sidebar popover'});
narrow.by('sender', email, {trigger: 'user sidebar popover'});
e.stopPropagation();
e.preventDefault();
});