paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Jump to conversation where message was sent.

Browse Source 
Removes two 'narrow_to_recipient' banners which were
shown after sending a message to a different conversation.

Now, the sender is narrowed to the conversation where
message was sent.

Fixes #29186.
This commit is contained in:
Prakhar Pratyush
2024-03-06 17:42:08 +05:30
committed by Tim Abbott
parent e959a392c9
commit e4cbca698d
10 changed files with 59 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
web/e2e-tests/edit.test.ts
View File

@@ -29,7 +29,7 @@ async function edit_stream_message(page: Page, content: string): Promise<void> {
await common.wait_for_fully_processed_message(page, content);
}
async function test_stream_message_edit(page: Page, message_list_id: number): Promise<void> {
async function test_stream_message_edit(page: Page): Promise<void> {
await common.send_message(page, "stream", {
stream_name: "Verona",
topic: "edits",
@@ -38,6 +38,7 @@ async function test_stream_message_edit(page: Page, message_list_id: number): Pr
await edit_stream_message(page, "test edited");
const message_list_id = await common.get_current_msg_list_id(page, true);
await common.check_messages_sent(page, message_list_id, [["Verona > edits", ["test edited"]]]);
}
@@ -76,7 +77,7 @@ async function test_edit_message_with_slash_me(page: Page): Promise<void> {
);
}
async function test_edit_private_message(page: Page, message_list_id: number): Promise<void> {
async function test_edit_private_message(page: Page): Promise<void> {
await common.send_message(page, "private", {
recipient: "cordelia@zulip.com",
content: "test editing pm",
@@ -87,6 +88,7 @@ async function test_edit_private_message(page: Page, message_list_id: number): P
await page.click(".message_edit_save");
await common.wait_for_fully_processed_message(page, "test edited pm");
const message_list_id = await common.get_current_msg_list_id(page, true);
await common.check_messages_sent(page, message_list_id, [
["You and Cordelia, Lear's daughter", ["test edited pm"]],
]);
@@ -96,11 +98,10 @@ async function edit_tests(page: Page): Promise<void> {
await common.log_in(page);
await page.click("#left-sidebar-navigation-list .top_left_all_messages");
await page.waitForSelector(".message-list .message_row", {visible: true});
const message_list_id = await common.get_current_msg_list_id(page, true);
await test_stream_message_edit(page, message_list_id);
await test_stream_message_edit(page);
await test_edit_message_with_slash_me(page);
await test_edit_private_message(page, message_list_id);
await test_edit_private_message(page);
}
common.run_test(edit_tests);