paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

dialog_widget: Assign each dialog widget a unique id.

Browse Source 
This makes it easy to check if the correct dialog widget is open
and to perform actions based on the state of dialog widget in
async callbacks.
This commit is contained in:
Aman Agrawal
2024-05-15 06:38:06 +00:00
committed by Tim Abbott
parent ab0fc402e0
commit e51962d6ac
10 changed files with 66 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/e2e-tests/custom-profile.test.ts
View File

@@ -15,7 +15,7 @@ async function test_add_new_profile_field(page: Page): Promise<void> {
"Add a new custom profile field",
);
assert.strictEqual(
await common.get_text_from_selector(page, "#dialog_widget_modal .dialog_submit_button"),
await common.get_text_from_selector(page, ".micromodal .dialog_submit_button"),
"Add",
);
await page.waitForSelector(".admin-profile-field-form", {visible: true});
@@ -23,7 +23,7 @@ async function test_add_new_profile_field(page: Page): Promise<void> {
field_type: "1",
name: "Teams",
});
await page.click("#dialog_widget_modal .dialog_submit_button");
await page.click(".micromodal .dialog_submit_button");
await common.wait_for_micromodal_to_close(page);
await page.waitForSelector(
@@ -43,13 +43,13 @@ async function test_edit_profile_field(page: Page): Promise<void> {
"Edit custom profile field",
);
assert.strictEqual(
await common.get_text_from_selector(page, "#dialog_widget_modal .dialog_submit_button"),
await common.get_text_from_selector(page, ".micromodal .dialog_submit_button"),
"Save changes",
);
await common.fill_form(page, "form.name-setting", {
name: "team",
});
await page.click("#dialog_widget_modal .dialog_submit_button");
await page.click(".micromodal .dialog_submit_button");
await common.wait_for_micromodal_to_close(page);
await page.waitForSelector(
@@ -69,10 +69,10 @@ async function test_delete_custom_profile_field(page: Page): Promise<void> {
"Delete custom profile field?",
);
assert.strictEqual(
await common.get_text_from_selector(page, "#dialog_widget_modal .dialog_submit_button"),
await common.get_text_from_selector(page, ".micromodal .dialog_submit_button"),
"Confirm",
);
await page.click("#dialog_widget_modal .dialog_submit_button");
await page.click(".micromodal .dialog_submit_button");
await common.wait_for_micromodal_to_close(page);
await page.waitForSelector("#admin-profile-field-status img", {visible: true});