paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

dialog_widget: Assign each dialog widget a unique id.

Browse Source 
This makes it easy to check if the correct dialog widget is open
and to perform actions based on the state of dialog widget in
async callbacks.
This commit is contained in:
Aman Agrawal
2024-05-15 06:38:06 +00:00
committed by Tim Abbott
parent ab0fc402e0
commit e51962d6ac
10 changed files with 66 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/e2e-tests/user-deactivation.test.ts
View File

@@ -32,11 +32,11 @@ async function test_reactivation_confirmation_modal(page: Page, fullname: string
"Unexpected title for reactivate user modal",
);
assert.strictEqual(
await common.get_text_from_selector(page, "#dialog_widget_modal .dialog_submit_button"),
await common.get_text_from_selector(page, ".micromodal .dialog_submit_button"),
"Confirm",
"Reactivate button has incorrect text.",
);
await page.click("#dialog_widget_modal .dialog_submit_button");
await page.click(".micromodal .dialog_submit_button");
await common.wait_for_micromodal_to_close(page);
}
@@ -53,11 +53,11 @@ async function test_deactivate_user(page: Page): Promise<void> {
"Unexpected title for deactivate user modal",
);
assert.strictEqual(
await common.get_text_from_selector(page, "#dialog_widget_modal .dialog_submit_button"),
await common.get_text_from_selector(page, ".micromodal .dialog_submit_button"),
"Deactivate",
"Deactivate button has incorrect text.",
);
await page.click("#dialog_widget_modal .dialog_submit_button");
await page.click(".micromodal .dialog_submit_button");
await common.wait_for_micromodal_to_close(page);
}
@@ -116,11 +116,11 @@ async function test_bot_deactivation_and_reactivation(page: Page): Promise<void>
"Unexpected title for deactivate bot modal",
);
assert.strictEqual(
await common.get_text_from_selector(page, "#dialog_widget_modal .dialog_submit_button"),
await common.get_text_from_selector(page, ".micromodal .dialog_submit_button"),
"Deactivate",
"Deactivate button has incorrect text.",
);
await page.click("#dialog_widget_modal .dialog_submit_button");
await page.click(".micromodal .dialog_submit_button");
await common.wait_for_micromodal_to_close(page);
await page.waitForSelector(default_bot_user_row + ".deactivated_user", {visible: true});